Change branch create and branch rename into normal commands
#3596
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiolms
force-pushed
the
feature/#3528-part1_make_branch_create_and_rename_normal_cmds
branch
4 times, most recently
from
3c7adf3
to
8b2779d
Compare
eamodio
force-pushed
the
feature/#3528-part1_make_branch_create_and_rename_normal_cmds
branch
from
8b2779d
to
09b08cb
Compare
eamodio
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
@sergiolms I pushed a bunch of changes to this. Please look through them and if you have any questions, let me know.
7 tasks
- Moves error handling outside of GitProviderService (to allow callers control over handling) - Splits unified branch command into specific calls and makes them optional Refs #3528
sergiolms
force-pushed
the
feature/#3528-part1_make_branch_create_and_rename_normal_cmds
branch
from
09b08cb
to
aae8254
Compare
sergiolms
deleted the
feature/#3528-part1_make_branch_create_and_rename_normal_cmds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first part of #3528 that changes
branch createandbranch renameinto normal commands.Since GitLens performs most of the validation for branch names, there wasn't really much to error check here.
Preparing next PR with
branch deletewhich will probably contain more validations.Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses